Re: [Xen-devel] [PATCH 2/3] add DomU xz kernel decompression

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Jan Beulich writes ("[Xen-devel] [PATCH 2/3] add DomU xz kernel decompression"):
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

I see this has already been committed, but:

> --- a/tools/libxc/xc_dom_bzimageloader.c
> +++ b/tools/libxc/xc_dom_bzimageloader.c
...
>  {
> -    lzma_stream stream = LZMA_STREAM_INIT;
> -    lzma_ret ret;
>      lzma_action action = LZMA_RUN;
>      unsigned char *out_buf;
>      unsigned char *tmp_buf;
> @@ -152,10 +151,9 @@ static int xc_try_lzma_decode(
>      int outsize;
>      const char *msg;
>  
> -    ret = lzma_alone_decoder(&stream, 128*1024*1024);
>      if ( ret != LZMA_OK )
>      {

I don't think this can possibly be correct.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel