Re: [Xen-devel] [PATCH R4 7/7] xen/balloon: Memory hotplug support for Xen balloon driver

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> -             credit = current_target() - balloon_stats.current_pages;
> +             credit = current_credit();
>  
> -             if (credit > 0)
> -                     state = increase_reservation(credit);
> +             if (credit > 0) {
> +                     if (balloon_is_inflated())
> +                             state = increase_reservation(credit);
> +                     else
> +                             state = reserve_additional_memory(credit);
> +             }

This code manipulation of where the current_target becomes current_credit
(and that logic) should be split off in its own patch.

Otherwise all the patches that touch Xen code look good.
>  
>               if (credit < 0)
>                       state = decrease_reservation(-credit);
> @@ -458,6 +594,14 @@ static int __init balloon_init(void)
>       balloon_stats.retry_count = 1;
>       balloon_stats.max_retry_count = 16;
>  
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> +     balloon_stats.hotplug_pages = 0;
> +     balloon_stats.balloon_hotplug = 0;
> +
> +     register_online_page_notifier(&xen_online_page_nb);
> +     register_memory_notifier(&xen_memory_nb);
> +#endif
> +
>       register_balloon(&balloon_sysdev);
>  
>       /*
> -- 
> 1.5.6.5
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel