Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 07.03.11 at 12:26, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>--- a/xen/arch/x86/x86_emulate/x86_emulate.c   Mon Mar 07 11:21:11 2011 +0000
>+++ b/xen/arch/x86/x86_emulate/x86_emulate.c   Mon Mar 07 11:21:11 2011 +0000
>@@ -2678,7 +2678,7 @@ x86_emulate(
>                 emulate_fpu_insn_memsrc("fiaddl", src.val);
>                 break;
>             case 1: /* fimul m64i */
>-                emulate_fpu_insn_memsrc("fimul", src.val);
>+                emulate_fpu_insn_memsrc("fimuls", src.val);

fimull.

>                 break;
>             case 2: /* ficom m64i */
>                 emulate_fpu_insn_memsrc("ficoml", src.val);

(Side note: The comments in this section are all wrong - they
should say "m32i"; there are no 64-bit integer operations
other than loads and stores.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel