[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement


  • To: Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Wed, 23 Feb 2011 11:35:40 +0000
  • Cc:
  • Delivery-date: Wed, 23 Feb 2011 03:36:40 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=ucyHTePAYarQCZfLtXLPUPL9dSFE9PfozLDSWSSm5LqF1+RCajLzR/qTr+2pVNpiqf b9VkUa6SmvBH9u204NG4l5gXxvzhFzD6nDKeFvxTtwKUIRB/ogQsBYOP/kei6n3WxSXY KPSulpE2vbBEDeAmhNopHyUuXygkhMfsdE07I=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcvTTcwUmgC0q2XUJ0GX6/lHZCuOvw==
  • Thread-topic: [Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement

On 23/02/2011 11:24, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> This was a leftover of converting from a switch to an if/else somewhere
> between 3.4 and 4.0.

So the patch is for 4.0-testing and unstable?

 -- Keir

> It also looks suspicious that MCEQUIRK_K7_BANK0 is not actually used
> anywhere. Perhaps amd_k7_mcheck_init() and amd_k8_mcheck_init() were
> intended to get (partially) folded?
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> --- a/xen/arch/x86/cpu/mcheck/amd_k8.c
> +++ b/xen/arch/x86/cpu/mcheck/amd_k8.c
> @@ -92,7 +92,6 @@ enum mcheck_type amd_k8_mcheck_init(stru
> /* Enable error reporting of all errors */
> wrmsrl(MSR_IA32_MCx_CTL(i), 0xffffffffffffffffULL);
> wrmsrl(MSR_IA32_MCx_STATUS(i), 0x0ULL);
> -   break;
> }
> }
>  
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.