Re: [Xen-devel] [PATCH linux-2.6.18-xen] blktap: make max # of tap devices a module parameter

[Laszlo Ersek <lersek@xxxxxxxxxx>]

On 02/22/11 18:44, Daniel Stodden wrote:

> I'm pretty sure minors>  256 date way before 2.6.32. Here's the module
> init fragment from blktap2, replacing the register_chrdev() call:
> 
> [...]

That's about what I was thinking of in [0]. It also sets the cdev's owner 
manually. However, register_chrdev() also does this:

   225          kobject_set_name(&cdev->kobj, "%s", name);
   226          for (s = strchr(kobject_name(&cdev->kobj),'/'); s; s = 
strchr(s, '/'))
   227                  *s = '!';

I reckon we can ignore the 's,/,!,g' replacement, since the name is fixed 
"blktap" (or "blktap2"). But the kobject name doesn't appear to be set in the 
first place. Is that no problem? If not, I'd just omit it from blktap as well.

Thank you!
lacos

[0] https://bugzilla.redhat.com/show_bug.cgi?id=452650#c21

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel