[Xen-devel] [PATCH 02/11] xen: use new schedop interface for suspend

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

Take the opportunity to comment on the semantics of the PV guest
suspend hypercall arguments.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 arch/x86/include/asm/xen/hypercall.h |   13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/xen/hypercall.h 
b/arch/x86/include/asm/xen/hypercall.h
index a3c28ae..a7d5823 100644
--- a/arch/x86/include/asm/xen/hypercall.h
+++ b/arch/x86/include/asm/xen/hypercall.h
@@ -422,10 +422,17 @@ HYPERVISOR_set_segment_base(int reg, unsigned long value)
 #endif
 
 static inline int
-HYPERVISOR_suspend(unsigned long srec)
+HYPERVISOR_suspend(unsigned long start_info_mfn)
 {
-       return _hypercall3(int, sched_op, SCHEDOP_shutdown,
-                          SHUTDOWN_suspend, srec);
+       struct sched_shutdown r = { .reason = SHUTDOWN_suspend };
+
+       /*
+        * For a PV guest the tools require that the start_info mfn be
+        * present in rdx/edx when the hypercall is made. Per the
+        * hypercall calling convention this is the third hypercall
+        * argument, which is start_info_mfn here.
+        */
+       return _hypercall3(int, sched_op_new, SCHEDOP_shutdown, &r, 
start_info_mfn);
 }
 
 static inline int
-- 
1.5.6.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel