Re: [Xen-devel] Re: [PATCH v6] Userspace grant communication

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 02/14/2011 11:38 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 14, 2011 at 11:14:03AM -0500, Konrad Rzeszutek Wilk wrote:
>> On Thu, Feb 03, 2011 at 12:18:58PM -0500, Daniel De Graaf wrote:
>>> Changes since v5:
>>>   - Added a tested xen version to workaround in #4
>>>   - Cleaned up variable names & structures
>>>   - Clarified some of the cleanup in gntalloc
>>>   - Removed copyright statement from public-domain files
>>>
>>> [PATCH 1/6] xen-gntdev: Change page limit to be global instead of per-open
>>> [PATCH 2/6] xen-gntdev: Use find_vma rather than iterating our vma list 
>>> manually
>>> [PATCH 3/6] xen-gntdev: Add reference counting to maps
>>> [PATCH 4/6] xen-gntdev: Support mapping in HVM domains
>>> [PATCH 5/6] xen-gntalloc: Userspace grant allocation driver
>>> [PATCH 6/6] xen/gntalloc,gntdev: Add unmap notify ioctl
>>
>> Hey Daniel,
>>
>> I took a look at the patchset and then the bug-fixes:
>>
>> Daniel De Graaf (12):
>>       xen-gntdev: Change page limit to be global instead of per-open
>>       xen-gntdev: Use find_vma rather than iterating our vma list manually
>>       xen-gntdev: Add reference counting to maps
>>       xen-gntdev: Support mapping in HVM domains
>>       xen-gntalloc: Userspace grant allocation driver
>>       xen/gntalloc,gntdev: Add unmap notify ioctl
>>       xen-gntdev: Fix memory leak when mmap fails
>>       xen-gntdev: Fix unmap notify on PV domains
>>       xen-gntdev: Use map->vma for checking map validity
>>       xen-gntdev: Avoid unmapping ranges twice
>>       xen-gntdev: prevent using UNMAP_NOTIFY_CLEAR_BYTE on read-only mappings
>>       xen-gntdev: Avoid double-mapping memory
>>
>>
>> And besides the two questions I posted today they look OK to me. However
> 
> Oh, and Jeremy's comment about the WARN_ON on the copy_to_user..
> 

I did post an updated version of that patch without the bad WARN_ON. It still
resolves to a WARN_ON in all paths, but it's at a higher level.

-- 
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel