Re: [Xen-devel] [PATCH] fix: domains do not get created when using vifname variable for bridged interfaces

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Patrick Scharrenberg writes ("[Xen-devel] [PATCH] fix: domains do not get 
created when using vifname variable for bridged interfaces"):
> In the two scripts vif-bridge and vif-route the variable containing
> the right interface-name, after an interface was renamed using
> "ifname", is $vif.  Otherwise hotplug can't handle renamed
> interfaces and prevents xm from creating domains.

This seems to be partly reverting 21922:0232bc7c9544 "tools/hotplug,
Use udev rules instead of qemu script to setup the bridge."

I can't exactly follow the logic of 21922 but it seems to me that the
bug is that in the case of an interface of type vif which is later
renamed (by the code around line 75 of vif-common.sh in xen-unstable),
the shell variable dev is not changed.

The change you are proposing would also an effect in the case of
interfaces of type tap and I'm not convinced that in this case it
would do the right thing.

Anthony, Stefano: as the authors of 21922 would you care to comment ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel