Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Fri, Jan 28, 2011 at 6:26 AM, Juergen Gross
<juergen.gross@xxxxxxxxxxxxxx> wrote:
> On 01/27/11 22:36, Andre Przywara wrote:
>>
>> Hi,
>>
>> the implementation of xl cpupool-numa-split is broken. It basically
>> deals with only one poolid, but there are two to consider: the one from
>> the original root CPUpool, the other from the newly created one.
>
> Uhh, silly copy and paste error! I think it happened when I introduced
> libxl_cpupool_cpuadd_node()...
> The correction is much easier. The root poolid is always 0. See attached
> patch.

Re patch itself: Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Re the cpupool interface:

Hang on; if the root poolid is always 0, why does xc_cpupool_create()
interpret a poolid of 0 as "XEN_SYSCTL_CPUPOOL_PAR_ANY"?  Doesn't that
mean that if you're trying to create a new cpupool from cpus in the
root pool, that you might get cpus from other pools?

If not, what's the point of the "CPUPOOL_PAR_ANY" parsing?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel