RE: [Xen-devel] [PATCH 1/2] xen-unstable/blkif: Move read/write/barrier specific fields into a union

[Owen Smith <owen.smith@xxxxxxxxxx>]

Attached is a patch that does not require any union of existing structures.

>From the previous patch series,
[PATCH 1/2] xen-unstable/blkif: is obsolete 
[PATCH 2/2] xen-unstable/blkif: is replaced by the attached patch.

The attached version 2 patch only adds definitions to the public header as 
suggested.


> -----Original Message-----
> From: Keir Fraser [mailto:keir.xen@xxxxxxxxx] On Behalf Of Keir Fraser
> Sent: 14 January 2011 17:05
> To: Owen Smith; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 1/2] xen-unstable/blkif: Move
> read/write/barrier specific fields into a union
> 
> Redefining the blkif_req struct naming seems an unnecessary pain. Why
> not
> define a separate 'struct blkif_trim_request' that starts with the
> uint8_t
> BLKIF_OP_TRIM and thereafter is defined exactly how you like? Then
> drivers
> can cast a request pointer to your new type when reading/writing a trim
> request, and no existing code needs to be changed. If all this does is
> introduce new definitions into xen-unstable, rather than changing
> existing
> ones, we could still potentially slip it in for 4.1.0 as an obviously
> safe
> patch.
> 
>  -- Keir
> 
> On 14/01/2011 16:44, "owen.smith@xxxxxxxxxx" <owen.smith@xxxxxxxxxx>
> wrote:
> 
> > From: Owen Smith <owen.smith@xxxxxxxxxx>
> >
> > # HG
> > changeset patch
> > # User root@xxxxxxxxxxxxxxxxxxxxxxx
> > # Date 1294919321 0
> > # Node ID 428420495fd3cfda164e7b355b0ffcc0845af2e4
> > # Parent  7b4c82f07281ad9c48b652e2a305a7be607c5283
> > blkif: Move read/write/barrier specific fields into a union
> >
> > Patches xen-unstable.hg
> >
> > Modifies the blkif ring interface by placing the request specific
> > fields into a union in order to support additional operation types.
> >
> > Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
>

Attachment: xen-unstable-addtrim-v2.patch
Description: xen-unstable-addtrim-v2.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel