[Xen-devel] RE: Avoid alloc for xsave before xsave_init

["Wei, Gang" <gang.wei@xxxxxxxxx>]

Keir Fraser wrote on 2011-01-14:
> On 13/01/2011 18:48, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
> 
>> While debugging some weird booting failure bugs, just found
>> currently, xsave_alloc_save_area will be called in
>> init_idle_domain->scheduler_init->alloc_vcpu->vcpu_initialise calls,
>> it is earlier than xsave_init called in identity_cpu(). This may
>> causing buffer overflow on xmem_pool. I am thinking about how to fix it.
> 
> I doubt idle vcpus need an xsave context. Can we check for
> is_idle_vcpu() in xsave_{alloc,free}_save_area()?
> 
> Is this an issue only for xen-unstable/4.1 (not 4.0)?

This issue was induced by c/s 22345 two months ago, which moved the xsave alloc 
code out from hvm_vcpu_initialise() to support pv guest but forget to exclude 
idle vcpus. It looks like not back pulled to 4.0. So only 4.1 suffers from it.

Jimmy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel