Re: [Xen-devel] [PATCH]: minios: eliminate compile warning - use of uninitialised variable

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Fri, 2011-01-07 at 17:21 +0000, Gianni Tedesco wrote:
> On Fri, 2011-01-07 at 16:58 +0000, Samuel Thibault wrote:
> > Gianni Tedesco, le Fri 07 Jan 2011 16:52:49 +0000, a Ãcrit :
> > > I'm not sure if this is a legit catch by gcc or a false positive due to
> > > extra cleverness in gcc-4.5. Either way it causes the build to barf.
> > 
> > It seems a false positive to me. What is the warning message?

Actually looks like these are incorrect when compiled 64bit and not
needed anyway. Following patch does the job.

diff -r 4695fd70077d extras/mini-os/lib/math.c
--- a/extras/mini-os/lib/math.c Fri Jan 07 17:13:53 2011 +0000
+++ b/extras/mini-os/lib/math.c Fri Jan 07 17:40:20 2011 +0000
@@ -59,9 +59,9 @@
 #include <mini-os/lib.h>
 #include <mini-os/time.h>
 
-       /* On ia64 these functions lead to crashes. These are replaced by
+       /* These functions are incorrect on 64bit. On ia64 they are replaced by
         * assembler functions. */
-#if !defined(__ia64__)
+#if !defined(__ia64__) && !defined(__x86_64__)
 
 /*
  * Depending on the desired operation, we view a `long long' (aka quad_t) in



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel