Re: [Xen-devel] [PATCH 04/12] Nested Virtualization: core

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 15:58 +0000 on 03 Jan (1294070335), Christoph Egger wrote:
> On Monday 27 December 2010 08:54:16 Dong, Eddie wrote:
> > This is overcomplicated. Static table should serve this much simple and
> > efficient.
> 
> The logic to select the right static table will be still needed. I am
> not sure if removing the _xmalloc() call simplifies this part a lot.
> 
> I appreciate opinions from other people on this.

I think that you should allocate the three static bitmaps once at boot
time and not bother refcounting them.  It's only 36KiB of overhead for
the entire host.

Otherwise you'd have to decide what to do if _xmalloc() returned NULL. 

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel