Re: [Xen-devel] [PATCH 4 of 6] REDO: mem_access & mem_access 2: HVMOPs for setting mem access

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 14:59 +0000 on 05 Jan (1294239568), Joe Epstein wrote:
>> Please arrange that these structs have the same size and layout in
>> 32-bit and 64-bit builds.  Otherwise you'll have to write compatibility
>> code for 32-bit tools running on 64-bit Xen, and nobody wants more of
>> that.  The easiest thing is to use explicitly-sized intXX_t throughout,
>> naturally aligned.
> 
> Sorry, I just copied set_mem_type, which also had an enum.  I'll force
> the bit size on the mem_access functions...would you want me to change
> set_mem_type (not my code) as well for consistency?

Yes please; if you could put it in a separate patch in the series that
would be great. 

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel