Re: [Xen-devel] [PATCH] pvops: fix "xm save -c" issue

[Kenji Wakamiya <wkenji@xxxxxxxxxxxxxx>]

Hi Konrad,

Konrad Rzeszutek Wilk wrote:
> > When the guest is unapused, stop_machine() in manage.c returns as the
> > suspend is cancelled. In that case, I think dpm_resume_end() should
> > not be called after stop_machine().
> >
> > I tested vbd and net, the guest did not hang.
> OK. Does 'xm save' (so no -c) and then resume work with this patch
> (I would think so, but I am curious whether you tested this).
>
> > But I'm not sure if this is a right way...
> Looks OK to me, just want to make sure that the normal 'xm save' still
> works after this.
I tested normal 'xm save' with this patch, and made sure it works well.

When normal save/restore is performed, the domain is suspended without
cancel, unlike 'save -c'. So, dpm_resume_end() is called. This
scenario haven't changed even after applying this patch.

Thanks,
--
Kenji Wakamiya



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel