Re: [Xen-devel] [PATCH] Enble 6 argument hypercalls for HVMs

[Keir Fraser <keir@xxxxxxx>]

On 15/12/2010 12:12, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> On 15.12.10 at 12:43, Keir Fraser <keir@xxxxxxx> wrote:
>> On 15/12/2010 10:40, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>>> Looking at this code also makes me wonder once again whether
>>> it really is a good idea to have a generally not taken forward
>>> branch here.
>> 
>> Which generally not-taken branch? The 'je 1f' instruction generally *will*
>> be taken!
> 
> Oops, of course - it being taken is the problem, as it'll be statically
> mis-predicted.

Well, moving the trace code out of line, perhaps into the fixup section,
would be good for cache locality. And then we would have a rarely taken
forward branch (since the fixup section comes after normal text).

I'm sure there are a bunch of places in our asm code where we could do this.
Feel free to fix them all up, if you like.

 -- Keir

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel