Re: [Xen-devel] [PATCH 2/5] libxl: strdup disk path before put it in qemu args array.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2010-12-09 at 19:42 +0000, anthony.perard@xxxxxxxxxx wrote:
> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> In libxl_build_device_model_args_new, the path to the disk image are
> freeed before there was actually use to make the arguments list of Qemu.
> The patch strdups it.
> ---
>  tools/libxl/libxl.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 0feb93f..0f6e632 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -1256,9 +1256,9 @@ static char ** 
> libxl_build_device_model_args_new(libxl__gc *gc,
>      if (!dm_args)
>          return NULL;
>  
> -    flexarray_set(dm_args, num++, "qemu-system-xen");
> -    flexarray_set(dm_args, num++, "-xen-domid");
> +    flexarray_set(dm_args, num++, "qemu-dm");

This bit doesn't seem to correspond to the patch description, was the
change deliberate or did it slip in by mistake?

(my kingdom for flexarray_append(...))

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel