[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] wrong vmexit size in xenalyze


  • To: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Fri, 19 Nov 2010 10:05:19 +0000
  • Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 19 Nov 2010 02:06:20 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=WQ7XGzgx9jHmAjvygnttXvrDHP685NGCcftVrNlAvUyrRYpVz0F2J71jaELhS6Ngl1 cIY9U18+8Nm7AkLGlpdgT2qf8rxncnsypXrJvtoMT7BKP2uWUIWpwk5C99SykdP4/L0O e9+bfwIyyLMN1k+YJdFWG5gY7c8FfH6quqEBY=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcuH0UVBPaNTh91AI0eghPhMSSZD2A==
  • Thread-topic: [Xen-devel] wrong vmexit size in xenalyze

On 19/11/2010 09:50, "George Dunlap" <George.Dunlap@xxxxxxxxxxxxx> wrote:

> Yeah, doing some archeology... looks like the trace size for the
> HVMTRACE_ND macro is has an off-by-one error since domain_id and vcpu_id
> were removed from HVM trace records in September 2008.
> 
> Tracing is definitely not a stable ABI between releases, but it should
> be reasonably stable after a release.
> 
> Originally I tried having xenalyze detect and deal with different trace
> layouts, but it made the code just too much of a mess.  I could have
> simply tagged xenalyze on a release, but then future improvements to
> xenalyze wouldn't be able to be used on released versions of Xen.

If there are a broader range of incompatibilties between 4.0 and 4.1 then
that makes sense. If the interface is pretty stable now, and it's just one
or two things like this, then maybe it was worth handling automatically.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.