Re: [Xen-devel] libxl: build fix

[John Haxby <john.haxby@xxxxxxxxxx>]

On 09/11/10 12:58, Christoph Egger wrote:
> On Tuesday 09 November 2010 12:54:45 Ian Jackson wrote:
> > Christoph Egger writes ("Re: [Xen-devel] libxl: build fix"):
> > > Attached patch replaces basename with strrchr(3).
> > ...
> >
> > > -        name = basename(filename);
> > > +        name = strrchr(filename, '/');
> Sorry, should be
>
>   name = strrchr(filename, '/') + 1;
No, it should be

    name = strrchr(filename, '/');
    if (name)
        name++;
    else
        name = filename;

In fact even that isn't right because basename(3) discards (or at least 
ignores) trailing '/' characters.
jch


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel