Re: [Xen-devel] Fix format warning for drivers/xen/blktap/device.c for xen/stable-2.6.32.x pvops commit 6c72eadd151f6f1b904989532a83988af0ea661a

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Tue, 2010-11-02 at 13:50 +0000, Teck Choon Giam wrote:
> From: Giam Teck Choon <giamteckchoon@xxxxxxxxx>
> 
> Fix compilation format warning in drivers/xen/blktap/device.c
> 
> drivers/xen/blktap/device.c: In function âblktap_device_createâ:
> drivers/xen/blktap/device.c:869: warning: format â%lluâ expects type
> âlong long unsigned intâ, but argument 5 has type âsector_tâ
> drivers/xen/blktap/device.c: In function âblktap_device_debugâ:
> drivers/xen/blktap/device.c:898: warning: format â%lluâ expects type
> âlong long unsigned intâ, but argument 4 has type âsector_tâ
> 
> Signed-off-by: Giam Teck Choon <giamteckchoon@xxxxxxxxx>

Seems reasonable to me.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  drivers/xen/blktap/device.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/blktap/device.c b/drivers/xen/blktap/device.c
> index e4fc23e..8f1d3a9 100644
> --- a/drivers/xen/blktap/device.c
> +++ b/drivers/xen/blktap/device.c
> @@ -867,7 +867,8 @@ blktap_device_create(struct blktap *tap, struct
> blktap_params *params)
>       set_bit(BLKTAP_DEVICE, &tap->dev_inuse);
> 
>       dev_info(disk_to_dev(gd), "sector-size: %u capacity: %llu\n",
> -              queue_logical_block_size(rq), get_capacity(gd));
> +              queue_logical_block_size(rq),
> +              (unsigned long long)get_capacity(gd));
> 
>       return 0;
> 
> @@ -895,7 +896,8 @@ blktap_device_debug(struct blktap *tap, char *buf,
> size_t size)
> 
>       s += snprintf(s, end - s,
>                     "disk capacity:%llu sector size:%u\n",
> -                   get_capacity(disk), queue_logical_block_size(q));
> +                   (unsigned long long)get_capacity(disk),
> +                   queue_logical_block_size(q));
> 
>       s += snprintf(s, end - s,
>                     "queue flags:%#lx plugged:%d stopped:%d empty:%d\n",



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel