Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 28.10.10 at 06:58, Haitao Shan <maillists.shan@xxxxxxxxx> wrote:
> This is the updated patch#2. Thanks.

Sorry, but this is worse than not checking at all: You didn't consider
the idle vCPU case here, and hence you may end up having more
features enabled in xcr0 for a guest than it should have.

Also I only now noticed that you're leaking the xsave_area allocation
in vcpu_initialize() if hvm_vcpu_initialise() fails.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel