[Xen-devel] [PATCH] xl: fix ballooning

[Andre Przywara <andre.przywara@xxxxxxx>]

Hi,

we should only check the value of new_target_memkb _after_ it has
been properly setup. This fixes ballooning Dom0, which
was broken since 22200:49a3c1721734.

Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12

diff -r cd193fa265b8 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Tue Oct 26 12:22:52 2010 +0100
+++ b/tools/libxl/libxl.c       Wed Oct 27 13:47:05 2010 +0200
@@ -2927,6 +2927,11 @@
         abort = 1;
         goto out;
     }
+    if (relative)
+        new_target_memkb = current_target_memkb + target_memkb;
+    else
+        new_target_memkb = target_memkb;
+
     if (!domid && new_target_memkb < LIBXL_MIN_DOM0_MEM) {
         LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
                 "new target for dom0 is below the minimum threshold\n");
@@ -2934,10 +2939,6 @@
         goto out;
     }
 
-    if (relative)
-        new_target_memkb = current_target_memkb + target_memkb;
-    else
-        new_target_memkb = target_memkb;
     if (new_target_memkb > memorykb) {
         LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
                 "memory_dynamic_max must be less than or equal to"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel