[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] migration fails with option "--live"



On Mon, 2010-10-25 at 08:04 +0100, Zhang, Yang Z wrote:
> It was introduced by 22275. 

Simple thinko on my part, thanks for reporting.

8<--------

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1288002211 -3600
# Node ID 3b832cf7c0f4e0c232c8d49be86fd86894f280e3
# Parent  3f41a2e6b6598df859df64966b39a0d0f6ccad03
libxc: correct xc_save utility's switch_qemu_logdirty callback return value

The callback return convention follows xc_domain_save and therefore
should return 1 on success.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 3f41a2e6b659 -r 3b832cf7c0f4 tools/xcutils/xc_save.c
--- a/tools/xcutils/xc_save.c   Fri Oct 22 10:27:01 2010 +0100
+++ b/tools/xcutils/xc_save.c   Mon Oct 25 11:23:31 2010 +0100
@@ -160,7 +160,7 @@ static int switch_qemu_logdirty(int domi
     free(cmd_str);
     free(ret_str);
 
-    return 0;
+    return 1;
 }
 
 int



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.