Re: [Xen-devel] [PATCH v4 03/10] xen: remap MSIs into pirqs when running as initial domain

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> > +   rc = HYPERVISOR_physdev_op(PHYSDEVOP_map_pirq, &map_irq);
> > +   if (rc) {
> > +           printk(KERN_WARNING "xen map irq failed %d\n", rc);
> > +
> > +           dynamic_irq_cleanup(irq);
> 
> Looking at include/linux/irq.h, I see this commment:
>  /*
> 330  * Dynamic irq helper functions. Obsolete. Use irq_alloc_desc* and
> 331  * irq_free_desc instead.
> 332  */
> 
> So we should use irq_free_desc instead of dynamic_irq_cleanup.
> (fyi, I didn't realize this until I started pulling in the sparse_irq
> patchset).

I looked at the rest of the patches and they all look good to me. Fix
this above and you can stick

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

on all the patches.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel