RE: [Xen-devel] [PATCH 3 of 3] xenpaging: Add check to xenpaging tool for EPT error from Xen

["Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>]

Patrick, Seems this patch is not in the upstream tree still?

Although this change is not that meaningful to user (user may have no idea of 
EPT at all), but at least it avoid the same error information ("Error 
initialising shared page") in two code, with totally different reason:

    /* Initialise shared page */
    paging->mem_event.shared_page = init_page();
    if ( paging->mem_event.shared_page == NULL )
    {
        ERROR("Error initialising shared page");
        goto err;
    }

and

   /* Initialise Xen */
    rc = xc_mem_event_enable(paging->xc_handle, paging->mem_event.domain_id,
                             paging->mem_event.shared_page,
                             paging->mem_event.ring_page);
    if ( rc != 0 )
    {
        ERROR("Error initialising shared page");
        goto err;
    }

Thanks
--jyh


>-----Original Message-----
>From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Patrick Colp
>Sent: Wednesday, July 28, 2010 5:21 AM
>To: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: [Xen-devel] [PATCH 3 of 3] xenpaging: Add check to xenpaging tool for 
>EPT
>error from Xen
>
># HG changeset patch
># User Patrick Colp <pjcolp@xxxxxxxxx>
># Date 1280265109 25200
># Node ID 4c37dd3811993b1ce173b3f5573be85cba1a53d9
># Parent  5a5bfb95a437cd860ab2da71c6534a2bef8fa558
>xenpaging: Add check to xenpaging tool for EPT error from Xen.
>
>Add a check in the xenpaging tool for the specific return code from Xen
>indicating that the target guest isn't using EPT. Return an appropriate
>error message so the user knows why xenpaging has failed.
>
>Signed-off-by: Patrick Colp <pjcolp@xxxxxxxxx>
>
>diff -r 5a5bfb95a437 -r 4c37dd381199 tools/xenpaging/xenpaging.c
>--- a/tools/xenpaging/xenpaging.c      Tue Jul 27 14:11:49 2010 -0700
>+++ b/tools/xenpaging/xenpaging.c      Tue Jul 27 14:11:49 2010 -0700
>@@ -121,7 +121,10 @@
>                              paging->mem_event.ring_page);
>     if ( rc != 0 )
>     {
>-        ERROR("Error initialising shared page");
>+        if ( errno == ENODEV )
>+            ERROR("EPT not supported for this guest");
>+        else
>+            ERROR("Error initialising mem-event connection");
>         goto err;
>     }
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel