Re: [Xen-devel] [PATCH, v3]: xl: randomly generate UUID's

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Thu, 2010-08-26 at 16:41 +0100, Christoph Egger wrote:
> @@ -2219,8 +2224,11 @@ static void list_domains(int verbose, co
>                  info[i].dying ? 'd' : '-',
>                  ((float)info[i].cpu_time / 1e9));
>          free(domname);
> -        if (verbose)
> -            printf(" " LIBXL_UUID_FMT,
> LIBXL_UUID_BYTES(info[i].uuid));
> +        if (verbose) {
> +            char buf[LIBXL_UUID_LEN];
> +            libxl_uuido_string(&info[i].uuid, buf, sizeof(buf));
> +            printf(" %s", buf);
> +        }
>          putchar('\n');
>      }
>  } 

Really? There's no way to keep the macro approach and get at the thing
like an array of bytes? If that's the case then how can
libxl_uuid_bytearray() that I introduced work correctly? I cannot tell
because your patch does not include libxl_uuid.h ...

Also I am not sure about the ocaml wrapper stuff but I will look in to
it for next time. I have to re-spin the patch to detect UUID parse
errors anyway.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel