Re: [Xen-devel] Re: libxl build failure in latest xen

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Tuesday 17 August 2010 13:43:37 Stefano Stabellini wrote:
> On Tue, 17 Aug 2010, Gianni Tedesco (3P) wrote:
> > On Tue, 2010-08-17 at 06:51 +0100, Jiang, Yunhong wrote:
> > > I always failed to build the xen in my enironment, with following error 
(my gcc version is 4.1.2):
> > > > gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g
> > > > -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
> > > > -Wno-unused-value -Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD
> > > > -MF .libxenlight.so.1.0.0.d  -D_LARGEFILE_SOURCE
> > > > -D_LARGEFILE64_SOURCE -Werror -Wno-format-zero-length -I. -fPIC
> > > > -I../../tools/libxc -I../../tools/include -I../../tools/libxc
> > > > -I../../tools/include -I../../tools/xenstore -I../../tools/include
> > > > -I../../tools/blktap2/control -I../../tools/blktap2/include
> > > > -I../../tools/include -Wl,-soname -Wl,libxenlight.so.1.0 -shared -o
> > > > libxenlight.so.1.0.0 flexarray.o libxl.o libxl_pci.o libxl_dom.o
> > > > libxl_exec.o libxl_xshelp.o libxl_device.o libxl_internal.o
> > > > xenguest.o libxl_utils.o osdeps.o libxl_paths.o libxl_bootloader.o
> > > > libxl_blktap2.o
> > > > /usr/bin/ld: libxl_dom.o: relocation R_X86_64_PC32 against
> > > > `hvm_build_set_params' can not be used when making a shared object;
> > > > recompile with -fPIC
> > > > /usr/bin/ld: final link failed: Bad value
> > > > collect2: ld returned 1 exit status
> > > > make: *** [libxenlight.so.1.0.0] Error 1

I reported the same error. See subject "libxl: link error"

> > >
> > > I suspect it is caused by changeset 21966, which add the hidden
> > > attribute, but didn't update the tools/libxl/xenguest.c. Following
> > > patch fix it, but I'm not sure if is right solution, can you please
> > > have a look?
> > >
> > > diff -r 6469a683b174 tools/libxl/xenguest.c
> > > --- a/tools/libxl/xenguest.c    Mon Aug 16 18:05:07 2010 +0100
> > > +++ b/tools/libxl/xenguest.c    Tue Aug 17 13:53:13 2010 +0800
> > > @@ -20,6 +20,7 @@
> > >  #include <string.h>
> > >
> > >  #include "libxl.h"
> > > +#include "libxl_internal.h"
> > >
> > >  int hvm_build_set_params(xc_interface *handle, uint32_t domid,
> > >                           libxl_domain_build_info *info,
> >
> > This looks like the correct fix to me.

This fix works for me.

Christoph


> > Somehow gcc 4.4.3 managed to work, but I don't understand how it could
> > possibly have:
> >
> > 183: 000000000001725c   357 FUNC    LOCAL  HIDDEN   12
> > hvm_build_set_params
> >
> > Can you apply this Stefano?
>
> Yes, I also think this is the correct fix.




-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel