Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[Xen-devel] [PATCH] add SONAME to libblktapctl.so"):
> Add an SONAME to libblktapctl.so.  Install static library as data to
> avoid executable permissions in the .a file.

Thanks.  I have a few comments:

> -libblktapctl.so: $(CTL_PICS)
> -     $(CC) $(CFLAGS) -fPIC -shared -rdynamic $^ -o $@
> +$(LIB_SHARED): $(CTL_PICS)
> +     $(CC) $(CFLAGS) $(LDFLAGS) -fPIC  -Wl,$(SONAME_LDFLAG) -Wl,$(LIBSONAME) 
> $(SHLIB_LDFLAGS) -rdynamic $^ -o $@

I'm not sure I understand why -fPIC appears here as a literal, rather
than being included via some more general make variable.  And does it
have any effect on the shared library creation link line anyway ?
Other places that make shared libraries don't have -fPIC there.

Likewise they don't say -rdynamic.

I appreciate that you're not doing anything here that wasn't in the
makefiles before.  So really I'm just asking if you or anyone else
knows anything about the reasons for this.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel