Re: [Xen-devel] [PATCH 1/2] libxl: const-correctness for libxl_uuid2string

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2010-07-29 at 18:31 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Looks ok to me.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxl/libxl.h     |    2 +-
>  tools/libxl/libxl_dom.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 191d1e1..3391491 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -360,7 +360,7 @@ int libxl_run_bootloader(libxl_ctx *ctx,
>                           libxl_device_disk *disk,
>                           uint32_t domid);
>  
> -char *libxl_uuid2string(libxl_ctx *ctx, uint8_t uuid[16]);
> +char *libxl_uuid2string(libxl_ctx *ctx, const uint8_t uuid[16]);
>    /* 0 means ERROR_ENOMEM, which we have logged */
>  
>  /* events handling */
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index b7ee27c..20a16e6 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -427,7 +427,7 @@ int save_device_model(libxl_ctx *ctx, uint32_t domid, int 
> fd)
>      return 0;
>  }
>  
> -char *libxl_uuid2string(libxl_ctx *ctx, uint8_t uuid[16]) {
> +char *libxl_uuid2string(libxl_ctx *ctx, const uint8_t uuid[16]) {
>      char *s = string_of_uuid(ctx, uuid);
>      if (!s) XL_LOG(ctx, XL_LOG_ERROR, "cannot allocate for uuid");
>      return s;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel