Re: [Xen-devel] [PATCH 3 of 9] libxl: signal caller if domain already destroyed on domain death event

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2010-07-26 at 15:32 +0100, Stefano Stabellini wrote:
> > +                ret = libxl_event_get_domain_death_info(&ctx, domid, 
> > &event, &info);
> > +
> > +                if (ret < 0) continue;
> [....]
> > +                    if (info.shutdown_reason != SHUTDOWN_suspend) {
> >                          LOG("Domain %d needs to be clean: destroying the 
> > domain", domid);
> >                          libxl_domain_destroy(&ctx, domid, 0);
> > -                        if (info.shutdown && info.shutdown_reason == 
> > SHUTDOWN_reboot) {
> > +                        if (info.shutdown_reason == SHUTDOWN_reboot) {
> 
> Isn't still possible to get here and have info.shutdown == 0 (and even
> info.dying == 0, after reading the fourth patch)?
> If so, the previous test is probably clearer.

Umm...

I think libxl_event_get_domain_death_info should have returned
ERROR_INVAL in that case and we'd have take the earlier if (ret < 0)
continue.

> The rest of the series looks fine.

Thanks.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel