[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH]: Fix rombios to correctly report size of disks >16GB


  • To: "Gianni Tedesco (3P)" <gianni.tedesco@xxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Fri, 23 Jul 2010 09:30:36 +0100
  • Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 23 Jul 2010 01:31:26 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcsqP1yKWWcl6qvARWGm3aJo1tBRhAAAfY5n
  • Thread-topic: [Xen-devel] [PATCH]: Fix rombios to correctly report size of disks >16GB

On 23/07/2010 09:14, "Gianni Tedesco (3P)" <gianni.tedesco@xxxxxxxxxx>
wrote:

>>> Also I'm not sure but I think the
>>> integer size here may be 16 bits, and the %u format specifier would only
>>> print 16-bit values in that case anyway.
>> 
>> I tested it and it works as advertised (modulo 16 -> 64)....
> 
> BTW. the reason for that is printf() and integer definition doesn't
> change regardless of whether gcc is compiling for 16 or 32 bit mode but
> just changes the logic wrt operand-size insn prefix

This isn't compiled with gcc, but with bcc from the dev86 toolchain. Hacking
sizeinmb to be 67UL<<10, I find that 67GB is printed which is correct.
That's with the latest dev86 (which is still very old!) v0.16.17.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.