Re: [Xen-devel] [PATCH] implement xl vncviewer

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 21 Jul 2010, Gianni Tedesco (3P) wrote:
> On Wed, 2010-07-21 at 16:54 +0100, Ian Jackson wrote:
> > Gianni Tedesco writes ("[Xen-devel] [PATCH] implement xl vncviewer"):
> > > +int libxl_vncviewer_exec(struct libxl_ctx *ctx, uint32_t domid, int 
> > > autopass)
> > > +{
> > 
> > I think this is the wrong interface.  What if I'm a management
> > interface and I want to provide a vnc: URL or something ?
> > 
> > The host/address and port information should be extractable from
> > libxl.
> > 
> > Ian.
> 
> I was following convention used for xenconsole exec. I think a
> management interface might want to find pty node too for example.
> 
> I could implement a further patch which includes a set of calls to
> expose orthogonal bits of functionality.
 
We could definitely improve the interface splitting the current
libxl_vncviewer_exec in two functions, one to get the vnc connection
details and the other one to fork and exec vncviewer.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel