Re: [Xen-devel] [PATCH,RFC] More consistent error handling in libxl

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 21 Jul 2010, Ian Jackson wrote:
> Gianni Tedesco writes ("[Xen-devel] [PATCH,RFC] More consistent error 
> handling in libxl"):
> > +    int rc;
> > +    rc = xc_domain_pause(ctx->xch, domid);
> > +    return libxl_xc_error(rc);
> 
> I'm afraid this pattern is wrong for two reasons.  Firstly,
> xc_domain_pause and functions like it do not return XC_ERROR_* values.
> They typically return -1 on error, and set errno.
> 
> Secondly, the error codes from libxc are not really all that useful.
> They mostly serve to identify where the error originated.
> 
> See the comment in xenctrl.h near line 70.
> 
 
The patch is an improvement over what we have now, besides
libxl_xc_error is capable of handling -1, even though it just returns
ERROR_FAIL in that case. The other libxc return codes might be useful so
it would be nice to keep them. We could make libxl_xc_error smarter too.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel