[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] fix PV on HVM on xen/next-2.6.32


  • To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
  • From: Łukasz Oleś <lukaszoles@xxxxxxxxx>
  • Date: Thu, 15 Jul 2010 12:58:22 +0200
  • Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 15 Jul 2010 03:59:56 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=JJWoaPfnKRuTD/1lUnoFnODRZf/6uuHmKiUu8qliF0Qv4Tfqjvqvi8957uHNAgSeKn k7o+9Iudifr2zyE9gj0JZcxO4da4A+fSZm4ArF3NVJUTug9pUuuGMUS5U6zGuSfYe9nK r+Cs+uq7rrWZ15X72bE8HDYuEqWYftwfUhW80=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

2010/7/14 Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>:
> Hi Jeremy,
> this patch makes PV on HVM work on xen/next-2.6.32: gsi and msi
> remapping is not supported when running as HVM guests yet.
>
> I am working on irq remapping for HVM guests and I have a prototype
> working already but I think this simple fix is worth applying now anyway
> to fix HVM guests with this kernel as soon as possible.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>
> ---
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 17a44e1..b896649 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -3505,7 +3505,7 @@ int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, 
> int type)
>        if (type == PCI_CAP_ID_MSI && nvec > 1)
>                return 1;
>
> -       if (xen_domain())
> +       if (xen_pv_domain())
>                return xen_pci_setup_msi_irqs(dev, nvec, type);
>
>        node = dev_to_node(&dev->dev);
> diff --git a/arch/x86/xen/pci.c b/arch/x86/xen/pci.c
> index 3def132..8ca31f1 100644
> --- a/arch/x86/xen/pci.c
> +++ b/arch/x86/xen/pci.c
> @@ -23,7 +23,7 @@ int xen_register_pirq(u32 gsi, int triggering)
>        int shareable = 0;
>        char *name;
>
> -       if (!xen_domain())
> +       if (!xen_pv_domain())
>                return -1;
>
>        if (triggering == ACPI_EDGE_SENSITIVE) {
> @@ -61,7 +61,7 @@ int xen_register_gsi(u32 gsi, int triggering, int polarity)
>        int rc, irq;
>        struct physdev_setup_gsi setup_gsi;
>
> -       if (!xen_domain())
> +       if (!xen_pv_domain())
>                return -1;
>
>        printk(KERN_DEBUG "xen: registering gsi %u triggering %d polarity 
> %d\n",

It was commited to xen/next and I tested it. Now it doesn't hang on
ACPI stuff. Thx Stefano.

Now I'm getting kernel panic(kernel BUG at
drivers/xen/balloon.c:528!), but I'll send another mail with bug
report.

-- 
Łukasz Oleś

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.