Re: [Xen-devel] [PATCH] Don't attach needless options when launch pygrub

[Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>]

Ian Campbell wrote:
>>> So it looks like specifying the kernel option in addition to bootloader
>>> is infact useful if you are booting a Solaris or Netware domU but is
>>> harmless/ignored otherwise. I think we need to continue to support this
>>  It seems that incfg will be returned directly if DomU is not Solaris,
>>
>> def sniff_solaris(fs, cfg):
>>     if not fs.file_exists("/platform/i86xpv/kernel/unix"):
>>         return cfg
>>
>>
>>     chosencfg = sniff_solaris(fs, incfg)
>>
>>  So, incfg change to chosencfg and then will be used.
> 
> Oh yes, this stuff seems needlessly complex, or at least prone to
> misreading, by me at least ;-)
> 

 OK, I'll try to fix this point.

>>  What about copy the specified 'kernel' from DomU to a temp file.
>> If there are 'bootloader' but no 'kernel', pygrub will copy and create temp 
>> file.
>> We can do the same things.
> 
> I think this is the current behaviour.
> 
> Ian.
> 

 Oh, yes. It seems that path of specified 'kernel' will be checked 
in configure_image(). We can delete this check if 'bootloader' is
existent.
 What's your opinion?


Yu

> 
> 
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel