[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] State of gdbsx in xen-4.0-testing.hg and debugger documentation.



Forgot patch tag in subject ...

On Fri, Jul 2, 2010 at 3:41 PM, Bruce Edge <bruce.edge@xxxxxxxxx> wrote:
On Fri, Jul 2, 2010 at 9:53 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
Bruce Edge writes ("Re: [Xen-devel] State of gdbsx in xen-4.0-testing.hg and debugger  documentation."):
> That would simplify the downstream packaging. They wouldn't need to provide
> an additional mechanism/hook/option to get gdbsx installed.
> The current debian packaging patch is a widely used "get this onto my box"
> aid, and it has no facility for tweaking the build options.

Sure.  Please submit a patch to wire it into tools/Makefile, or
wherever is appropriate.

Here is a patch to enable gdbsx by default.

--- xen-4.0-testing.hg-07.02.10/tools/Makefile  2010-07-02 10:30:40.000000000 -0700
+++ xen-4.0-testing.hg/tools/Makefile   2010-07-02 11:25:04.000000000 -0700
@@ -36,6 +36,7 @@
 SUBDIRS-y += libxl
 SUBDIRS-y += remus
 SUBDIRS-$(CONFIG_X86) += xenpaging
+SUBDIRS-y += debugger/gdbsx
 
 # These don't cross-compile
 ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
@@ -134,3 +135,8 @@
                $(MAKE) -C ocaml-xenstored clean; \
        fi
 
+subdir-clean-debugger/gdbsx:
+       $(MAKE) -C debugger/gdbsx clean
+
+subdir-install-debugger/gdbsx:
+       $(MAKE) -C debugger/gdbsx install
--- xen-4.0-testing.hg-07.02.10/xen/Rules.mk    2010-07-02 10:30:41.000000000 -0700
+++ xen-4.0-testing.hg/xen/Rules.mk     2010-07-02 11:58:23.000000000 -0700
@@ -8,7 +8,7 @@
 perfc_arrays  ?= n
 lock_profile  ?= n
 crash_debug   ?= n
-gdbsx         ?= n
+gdbsx         ?= y
 frame_pointer ?= n
 
 XEN_ROOT=$(BASEDIR)/..

------------cut------------

I suppose it would be cleaner to eliminate the debugger dir as gdbsx is the only one under there that's used and that would enable the tools/Rules.mk templates to cover the 
    subdir-clean-gdbsx:
    subdir-install-gdbsx
targets and not require them to be explicit in tools/Makefile

Also, I don't know if 
    SUBDIRS-y += debugger/gdbsx
should be conditional on any type of target, CONFIG_X86 or?

-Bruce
 
Thanks,
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.