[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: One question to p2m type


  • To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
  • From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
  • Date: Thu, 1 Jul 2010 15:08:24 +0800
  • Accept-language: en-US
  • Acceptlanguage: en-US
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 01 Jul 2010 00:09:47 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcsWzAAr70RJm+O0QbOzm9NterfqfQCICA+Q
  • Thread-topic: One question to p2m type

>-----Original Message-----
>From: Tim Deegan [mailto:Tim.Deegan@xxxxxxxxxx]
>Sent: Monday, June 28, 2010 10:13 PM
>To: Jiang, Yunhong
>Cc: xen-devel
>Subject: Re: One question to p2m type
>
>Hi,
>
>At 10:57 +0100 on 28 Jun (1277722666), Jiang, Yunhong wrote:
>> As you reminded before, in PAE environment, p2m type can only hold 8
>> types in total, that means we should not have > p2m_grant_map_ro in
>> p2m table.
>>
>> However, I didn't find any code to make sure this. For example, I
>> didn't find any code to make sure mem_paging_domctl can't execut in
>> PAE environment. Is it because p2m_change_type to >8 type will only
>> impact guet itself, and we don't need to care for it?
>
>No, that looks like an oversight.  All that memory-event code relies on
>having enough p2m types available and probably shouldn't even be
>compiled on PAE Xen.  It's certainly not expected to fail gracefully.
>I'll knock up a patch.

Really thanks for clarification.

--jyh

>
>Thanks,
>
>Tim.
>
>--
>Tim Deegan <Tim.Deegan@xxxxxxxxxx>
>Principal Software Engineer, XenServer Engineering
>Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.