Re: [Xen-devel] Freeze on boot pv domU 2.6.31 with Xen 4.1

[Steven Smith <steven.smith@xxxxxxxxxx>]

> > I upgraded Xen to the last revision on the repository (21446) and
> > installed it. 2.6.31.13 kernel (branch xen/stable-2.6.31.x) do not
> > hang at boot time anymore (I have a 2.6.31.13 kernel on both Dom0 and
> > pv DomU).
> >
> > Netchannel2 is added (and appears in guest), nevertheless, I get a
> > triple fault from Xen's kernel when I try to start a dhcp client on
> > the netchannel2 interface. Here is the crash report on Xen's console :
> nc2 is very untested, so it isn't surprising that you're having problems
> with it.  Steven, do you have any thoughts about this?
Does the attached patch help?

Steven.

commit 49b5467d72943a4f257fb6b926bbdd47bfff230c
Author: Steven Smith <ssmith@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Date:   Wed Jun 2 19:56:18 2010 +0100

    Fix stupid use of integer offset as pointer.
    
    Signed-off-by: Steven Smith <ssmith@xxxxxxxxxxxxx>

diff --git a/drivers/net/xen-netchannel2/util.c 
b/drivers/net/xen-netchannel2/util.c
index 0d242a4..e8c3118 100644
--- a/drivers/net/xen-netchannel2/util.c
+++ b/drivers/net/xen-netchannel2/util.c
@@ -142,7 +142,7 @@ void pull_through(struct sk_buff *skb, unsigned count)
                if (this_frag > count)
                        this_frag = count;
                va = page_address(skb_shinfo(skb)->frags[frag].page);
-               buf = skb->tail;
+               buf = skb_tail_pointer(skb);
                memcpy(buf, va + skb_shinfo(skb)->frags[frag].page_offset,
                       this_frag);
                skb->tail += this_frag;

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel