[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xen crash related to pci passthrough

This is only tangentially related, but...

In xen/arch/x86/irq.c:__pirq_guest_unbind() this code looks wrong to me:

    memmove(&action->guest[i], &action->guest[i+1], IRQ_MAX_GUESTS-i-1);

Should it be:

memmove(&action->guest[i], &action->guest[i+1], sizeof(action->guest[0])*(IRQ_MAX_GUESTS-i-1));




On 27/05/10 22:02, Jeremy Fitzhardinge wrote:
On 05/27/2010 01:02 PM, Keir Fraser wrote:
On 27/05/2010 20:51, "Jeremy Fitzhardinge"<jeremy@xxxxxxxx>  wrote:

    3. attach device to PV domU
       dom0# xl pci-attach f13pv64 0000:03:00.0
    4. unbind from pciback
       dom0# echo 0000:03:00.0>  /sys/bus/pci/drivers/pciback/unbind
    5. rmmod driver in domU
       domU# rmmod e1000e
    6. Crash!

The device in question is an Intel 82574L ethernet controller, using
msi-x interrupts.

What happens if you pci-detach before unbinding from pciback? Not that Xen
should crash of course, but a crash resulting from a mistake in detach
ordring in dom0 would be less worrying than some alternatives.

Doing things in a more sensible order (rmmod in domU, detach, unbind)
seems to work OK.  I was deliberately seeing what would happen if I
tried pulling the device out from under a domain.


Xen-devel mailing list

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.