Re: [Xen-devel] [PATCH]: blktap2 : control function

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Fri, May 21, 2010 at 08:51:12PM +0400, eXeC001er wrote:
>    Hi.
>    I tried to create small patch for blktap2 : control function:
>

This patch is horribly broken at least for me.. It looks really weird.
You might want to re-send it in a proper format..

.. Or if it works for others just forget about this rant:)

-- Pasi

>    diff -r 840f269d95fb tools/python/xen/xend/XendDomainInfo.py
>    --- a/tools/python/xen/xend/XendDomainInfo.py   Wed May 19 22:59:52 2010
>    +0100
>    +++ b/tools/python/xen/xend/XendDomainInfo.py   Fri May 21 20:17:15 2010
>    +0400
>    @@ -3292,6 +3292,7 @@
>    Â Â  Â  Â  Â  Â  Â  Â  Â  fn = BOOTLOADER_LOOPBACK_DEVICE
>    Â
>    Â Â  Â  Â  Â  Â  Â  try:
>    + Â  Â  Â  Â  Â  Â  Â  Â time.sleep(5)
>    Â Â  Â  Â  Â  Â  Â  Â  Â  blcfg = bootloader(blexec, fn, self, False,
>    Â Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â bootloader_args,
>    kernel, ramdisk, args)
>    Â Â  Â  Â  Â  Â  Â  finally:
>    @@ -3299,7 +3300,7 @@
>    Â Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  [1]log.info("Unmounting %s from %s." %
>    Â Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â (fn,
>    BOOTLOADER_LOOPBACK_DEVICE))
>    Â
>    - Â  Â  Â  Â  Â  Â  Â  Â  Â  Â dom0.destroyDevice('tap',
>    BOOTLOADER_LOOPBACK_DEVICE)
>    + Â  Â  Â  Â  Â  Â  Â  Â  Â  Â dom0.destroyDevice(devtype,
>    BOOTLOADER_LOOPBACK_DEVICE)
>    Â
>    Â Â  Â  Â  Â  Â  Â  if blcfg is None:
>    Â Â  Â  Â  Â  Â  Â  Â  Â  msg = "Had a bootloader specified, but can't
>    find disk"
>    With this patch DomU boot from VHD disk without error.
>    But i can not fix other bug:
>    if after DomU (boot disk is blktap2-type) stopped i can not start it
>    again, because i get error "raise VmError("Device %s is already
>    connected." % dev_str)" in "DevController.py".
>    but i found workaround:
>    stop blktap2_mount: echo 1 >Â /sys/class/blktap2/blktapX/remove
>    remove records from xenstore:Â
>    xenstore-rm /vm/00000000-0000-0000-0000-000000000000
>    xenstore-write /local/domain/0/vm ""
>    Now i can run my DomU again.
> 
> References
> 
>    Visible links
>    1. http://log.info/

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel