[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] ACPI suspend/resume on Dell Inspirons 1464/1564/1764

  • To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Roger Cruz" <roger.cruz@xxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 19 May 2010 14:41:01 -0500
  • Cc:
  • Delivery-date: Wed, 19 May 2010 12:44:05 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acrr2MGaf7yfnFaQTZycCDfaoiD3fwGKD9vEATZRItYAEo2wXAAOFwx+AARLdsgABrWIvgAAlmIt
  • Thread-topic: [Xen-devel] ACPI suspend/resume on Dell Inspirons 1464/1564/1764

OK.  My patch attempted to preserve the changes across the global variables as that is what I thought the intent was.  If I understood you right, the changes in construct_vmcs don't need to apply to future vmcs creations so the changes may only be done locally. 

When do you think an official patch will be available?

Thank you.

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
Sent: Wed 5/19/2010 3:24 PM
To: Roger Cruz; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] ACPI suspend/resume on Dell Inspirons 1464/1564/1764

On 19/05/2010 17:36, "Roger Cruz" <roger.cruz@xxxxxxxxxxxxxxxxxxx> wrote:

>    else
>     {
>         v->arch.hvm_vmx.secondary_exec_control &= ~SECONDARY_EXEC_ENABLE_EPT;
>         vmx_vmexit_control &= ~(VM_EXIT_SAVE_GUEST_PAT |
>                                 VM_EXIT_LOAD_HOST_PAT);
>         vmx_vmentry_control &= ~VM_ENTRY_LOAD_GUEST_PAT;
>     }

This is the bug. construct_vmcs() should make local copies of
vmx_vmexit_control and vmx_vmentry_control, and only clear bits in those
local copies. It should then __vmwrite() those local copies. I will make a
patch and apply to xen-unstable and xen-4.0 and xen-3.4.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.