[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH]xl: Add missing start_time entry when create and restore VMs

On 05/14/2010 11:47 PM, Dan Magenheimer wrote:
>> + vments[5] = libxl_sprintf(ctx, "%lu.%d", 
>> start_time.tv_sec,(int)start_time.tv_usec/10000);
>> + vments[i++] = libxl_sprintf(ctx, 
>> "%lu.%d",start_time.tv_sec,(int)start_time.tv_usec/10000);
> I don't think these work as intended.  For example, if
> tv_usec is 10000, I think you want xxx.01 printed, not
> xxx.1.  Maybe you want %lu.%02d?

Ah sorry, you're right, I'll fix that, Thank you.

> And in any case, is there a reason to limit the precision
> to two digits?  Why not %lu.%06d?

I see no reason too. But the current start_time is limit to
two digits(vms created from 'xm create'). So I limit the
precision to two digits.


Yang Hongyang

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.