[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PATCH] dom0 vcpu set problem

  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
  • Date: Tue, 11 May 2010 11:07:30 +0200
  • Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
  • Delivery-date: Tue, 11 May 2010 02:08:09 -0700
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:From:To:Subject:Date:User-Agent:Cc: References:In-Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id; b=XKI1nyImznTtyKAX2buxJ1gbBz5RES2qQh+6DECHmn16JnPT/9C10/C3 c8hERq6+oqCPZ12yEVW9Z9NMVEWxzL/UGKs6EitFSD2cNYSPZiu4gHjyD abtKlK/9LxWxu3iJ9v0Id6q8UMbtxwqoBLpvtigHdlpHcHuP7EM/YFNp3 SXZCoTbhCD8BHIMV3dk9YACiJZS/Wv1xBh5I2b8xjeKueld3xKIWUGyuL PkSWqHammH+sDm41zfpJIKaEPiVeI;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Am 11.05.2010 schrieb Jan Beulich:
> >>> Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx> 11.05.10 08:19 >>>
> >Can anybody point me where in the code the acpi cpu hotplug gets triggered to
> >add the vcpu again to the dom0 kernel after setting the xenstore!
> No, ACPI hotplug code is not involved in pv domains' vCPU adding or
> removal. Instead, the pv kernels create a xenstore watch on their
> domain's "cpu" node, reading cpu/<id>/availability when the watch
> fires. See drivers/xen/core/cpu_hotplug.c (for the forward ported
> kernels) or drivers/xen/cpu_hotplug.c (for the pv-ops ones).
> Jan

It's the pv-ops kernel from within the xen-4.0-testing.hg tree.
Thanks, Jan ;-)
Pointing to the right place I found a missing cpu_up() call
in the vcpu_hotplug() function.
Now all my vcpus are back again on my machine ;-)


Signed-off-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>

diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
index bdfd584..f3f0c1e 100644
--- a/drivers/xen/cpu_hotplug.c
+++ b/drivers/xen/cpu_hotplug.c
@@ -49,6 +49,7 @@ static void vcpu_hotplug(unsigned int cpu)
        switch (vcpu_online(cpu)) {
        case 1:
+               (void)cpu_up(cpu);
        case 0:

Company details: http://ts.fujitsu.com/imprint.html

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.