[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] vncpassword support in libxl

Ian Jackson wrote:
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] vncpassword support in 
The indentation is often wrong and sometimes you are adding\removing
blank lines for no reason.
But apart from this small cosmetic issues the patch looks good.

You missed that he removed this line:

-    printf("Parsing config file %s\n", config_file);

This demonstrates why patches with spurious stuff in should be
rejected - it's too easy to miss a mistake when scanning past a lot of
spurious changes.


Yes my mad will do the changes and resubmit again

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.