[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] cpupools and locking

  • To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Wed, 05 May 2010 13:07:02 +0200
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 05 May 2010 04:08:01 -0700
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=M5kD4JUYaDFg9XtvGyL0Hal+Rsw4L20nco3e86rDkzFA18wLO+Psdo3U U/waIHyUjwjzWvgvmmhYEaA1oxFIythaCMMAUnrRimXpy46dF1VVvkdVH I/g2T3jp6ZshhcauYcZ1VOCBIuprzGghEh9ZJOGuvYd7fzrr+YSgD1xiA YvndACFQ4EjgXDba9B97eu7QN8/fn4xy1m5bFR3zFDjorEnTuMaDnfibp 3kY/wfHUF0ImTjmRjkISSUlqj421C;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 05/05/2010 11:00 AM, Keir Fraser wrote:
On 05/05/2010 06:25, "Juergen Gross"<juergen.gross@xxxxxxxxxxxxxx>  wrote:

cpupool_do_domctl is called always while the domctl lock is being held. Maybe
I should have added a comment to document this assumption.

Yes please. Even better would be to explicitly add your own big lock in
cpupool.c, just for clarity. And why do you need your 'little' lock around
the lookup operations at all, in that case? It seems unnecessary if you have
a bigger lock protecting you; yet insufficient if you do not.

That's the best solution, I think. Patch attached.


Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Attachment: poollock.patch
Description: Text Data

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.