Re: [Xen-devel] [PATCH 3 of 6] evtchn delivery on HVM

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 22 Apr 2010, Konrad Rzeszutek Wilk wrote:
> > +
> > +   if (xen_feature(XENFEAT_hvm_callback_vector)) {
> > +           callback_via = HVM_CALLBACK_VECTOR(X86_PLATFORM_IPI_VECTOR);
> > +           xen_set_callback_via(callback_via);
> > +           x86_platform_ipi_callback = do_hvm_pv_evtchn_intr;
> > +           xen_have_vector_callback = 1;
> 
> OK, so you are using the IPI vector. And the value is:
> 
> > +#define HVM_CALLBACK_VIA_TYPE_VECTOR 0x2
> > +#define HVM_CALLBACK_VIA_TYPE_SHIFT 56
> > +#define HVM_CALLBACK_VECTOR(x) (((uint64_t)HVM_CALLBACK_VIA_TYPE_VECTOR)<<\
> > +                               HVM_CALLBACK_VIA_TYPE_SHIFT | (x))
> > +
> >  #endif /* XEN_HVM_H__ */
> 
>  2 << 56 || 0xed.
> 
> But looking back at the other patch, the arguments that are supposed
> to be set/get via the  HVM_PARAM_CALLBACK_IRQ call are:
> 
>  * How should CPU0 event-channel notifications be delivered?
> + * val[63:56] == 0: val[55:0] is a delivery GSI (Global System
> Interrupt).
> + * val[63:56] == 1: val[55:0] is a delivery PCI INTx line, as follows:
> + *                  Domain = val[47:32], Bus  = val[31:16],
> + *                  DevFn  = val[15: 8], IntX = val[ 1: 0]
> + * If val == 0 then CPU0 event-channel notifications are not delivered.
> 
> I don't see val[63:56] == 2 ?
> 

the comment on the other patch needs to be update as well


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel