Re: [Xen-devel] [PATCH] libfsimage: zfs build fix

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 15/04/2010 16:51, "Mark Johnson" <johnson.nh@xxxxxxxxx> wrote:

> On Thu, Apr 15, 2010 at 10:10 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> wrote:
>> Christoph Egger writes ("[Xen-devel] [PATCH] libfsimage: zfs build fix"):
>>> Attached patch makes libfsimage build again on NetBSD.
> 
> The fsimage zfs patch was changed around to make it simpler
> to keep in sync with the grub changes.  fsys_zfs.c, etc are exact copies
> of what's in grub  e.g.
>     
> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/grub/grub-0.97/s
> tage2/fsys_zfs.c
> 
> fsi_zfs.* are kludges to get the grub code to fit into libfsimage and
> is the only code which is different from the grub code.
> 
> It would be easier to keep in sync if this would be continued.

Unfortunately with -Wall the zfs sources spewed a quite unreasonable number
of warnings. Enough for me to get annoyed, go clean them all up, and add
-Werror.

I don't know how important it is to keep the files identical? It's not like
interfaces or anything have been changed: all the modifications are trivial
one-liners. Basically, it should still be possible to dump a new version of
the zfs code into our tree sometime down the line, and then go xfix up the
build warnings again (it didn't take that long). Doesn't that suffice? You
could even try getting GRUB guys to accept our build cleanups upstream (fat
chance given my previous experiences with them, I'll admit). ;-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel