Re: [Xen-devel] [PATCH] xen: move viridian defines to header

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 01/04/2010 09:30, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> 
> Hi!
> 
> Attached patch moves viridian defines into viridian header.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

I don't consider this a clean up by itself. It's nicer to define things in a
.c file if they are only sued in that .c file. Also moving the MSRs out but
not other viridian-architectural defines like the MSR flag definitions and
hypercall status codes seems inconsistent.

I would consider this as part of a patch series where later patches that I
actually care about make use of this change. On its own, it gets a nack.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel