[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: [PATCH] [retry 3] Refactor Xen support for Intel Turbo Boost



> -----Original Message-----
> From: Mark Langsdorf [mailto:mark.langsdorf@xxxxxxx]
> Sent: Thursday, April 01, 2010 3:25 AM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx; Yu, Ke
> Subject: [PATCH] [retry 3] Refactor Xen support for Intel Turbo Boost
> 
> diff -r ebd84be3420a -r e86769595f59 tools/libxc/xenctrl.h
> --- a/tools/libxc/xenctrl.h   Tue Mar 30 18:31:39 2010 +0100
> +++ b/tools/libxc/xenctrl.h   Wed Mar 31 13:58:13 2010 -0500
> @@ -1281,7 +1281,10 @@
>      union {
>          xc_userspace_t userspace;
>          xc_ondemand_t ondemand;
> +        uint32_t pad[4];
>      } u;
> +
> +    int32_t turbo_enabled;
>  };

xen_get_cpufreq_para.u and xc_get_cpufreq_para.u should have the same 
definition, since current code (xc_get_cpufreq_para function) use memcpy to 
transfer data between xen_get_cpufreq_para.u and xc_get_cpufreq_para.u. So 
padding is not needed here, as we discussed in previous email.

> 
>  int xc_get_cpufreq_para(int xc_handle, int cpuid,
> diff -r ebd84be3420a -r e86769595f59
> xen/include/acpi/cpufreq/processor_perf.h
> --- a/xen/include/acpi/cpufreq/processor_perf.h       Tue Mar 30 18:31:39
> 2010 +0100
> +++ b/xen/include/acpi/cpufreq/processor_perf.h       Wed Mar 31 13:58:13
> 2010 -0500
> @@ -9,6 +9,7 @@
>  int get_cpu_id(u8);
>  int powernow_cpufreq_init(void);
>  unsigned int powernow_register_driver(void);
> +unsigned int get_measured_perf(unsigned int cpu, unsigned int flag);

Shouldn't this be in patch 3?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.