[Xen-devel] Re: xen: use paging_mode_hap()

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Wednesday 31 March 2010 11:29:32 Tim Deegan wrote:
> At 16:51 +0100 on 30 Mar (1269967863), Christoph Egger wrote:
> > Hi!
> >
> > Attached patch makes xen consequently use paging_mode_hap().
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> >
> > P.S.: This is a resend. Needs ack from Tim.
>
> Nack, at least in its current form - paging_mode_hap(d) is not the same
> as d->arch.hvm_domain.hap_enabled.  Especially in paging.c, where we
> test hap_enabled to gate whether we should call the function that makes
> paging_mode_hap(d) true!
>
> I think the p2m.c changes are wrong too, since the p2m init code is
> called from hap_enable before it writes PG_HAP_enable to the paging
> mode.  (That's probably a bug in its own right; it should set the mode
> and then call the p2m code, and shadow should do likewise, and then
> these changes would be correct and desirable).
>
> The other substitutions are probably OK.
>
> Cheers,
>
> Tim.

Thanks for you comments. Attached is my updated patch.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: xen_pagingmode.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel